QA Invite Users

[cgardens]

This feature has never worked properly. We need to figure out its current state and get it to a working state before the launch.

QA Checklist

• - invite to a workspace a user that does not yet have an Airbyte account.
• - invite to a workspace a user that does not yet have an Airbyte account should alert that the user does not exist and they first must create an account.
• - invite to a workspace a user that does already have an Airbyte account.
• - should not be able to add a user multiple times (@tuliren to do this)
  • https://github.com/airbytehq/airbyte-cloud/pull/318
• - hide role in UI when inviting a user
  • This field is now disabled.

[cgardens]

related issues:
https://github.com/airbytehq/airbyte-internal-issues/issues/214
#5449

[tuliren]

Here is my QA summary without knowing what is the expected user flow.

Invite to a workspace a user that does NOT yet have an Airbyte account.

Issues:

• It is unclear if I must select a role or not.
  • This is probably not a required field, since I can click the submission button without selecting a role.
• There is only an admin role. Should we also have a user role?
  • Since role is not required, I guess not selecting any role is equivalent to a user role. But it's better to make this explicit.
• Once a role is selected, there is no way to unselect it.
  • This is a problem if not selecting a role is equivalent to a user role.

• When adding a new user, I cannot submit the form. A warning only shows up in the browser console:

console.js:107 Warning: An unhandled error was caught from submitForm() Error: Object not found. User liren+user1@airbyte.io does not exist yet. Please sign-up manually and add to workspace once user is created
    at AirbyteRequestService.ts:75
    at l (runtime.js:63)
    at Generator._invoke (runtime.js:293)
    at Generator.next (runtime.js:118)
    at r (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)

Invite to a workspace a user that does already have an Airbyte account.

Adding a registered user for the first time works.

Issues:

• Users are automatically added as admin, even if admin role is not selected.
• The same user can be added multiple times.

Additionally issues related to account management

• The remove button is clickable but does not actually remove the user.
• The remove button is clickable even for the currently logged in user.
  • Because this button currently does not work, so I cannot test what will happen if the last user is removed from the workspace.
  • A user probably should not be able to remove herself? Or at least the super admin, if there is such a role, should not be able to remove herself. Otherwise, all users can be removed from the workspace, and the workspace becomes a phantom one.

[jrhizor]

Which environment are you testing on (and which version of core/cloud)?

[tuliren]

Which environment are you testing on (and which version of core/cloud)?

I tested on the production site, which does not show a version. Should I do it on the dev site?

[jrhizor]

Prod is good. I looked up the version of core and cloud from Kubernetes on the cloud console.

[ChristopheDuong]

When adding a new user, I cannot submit the form. A warning only shows up in the browser console:

From past discussions, we had mentioned about a pop-up (not just a warning in console) when this happens as a workaround:

[davinchia]

QA for current prod deployment. Looks like it's working:

invited a user:

verified email:

logged in to new user and saw new workspace:

revoke the user:

(disappears from inviter)

(disappears from invitee)

[davinchia]

@cgardens this looks good on prod. think we can close it