Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source Hubspot: Fix SAT incremental tests #6509

Closed
htrueman opened this issue Sep 28, 2021 · 1 comment
Closed

馃悰 Source Hubspot: Fix SAT incremental tests #6509

htrueman opened this issue Sep 28, 2021 · 1 comment
Assignees
Labels

Comments

@htrueman
Copy link
Contributor

Enviroment

  • Airbyte version: 0.1.24

  • OS Version / Instance: any

  • Source Connector and version: Hubspot 0.1.16

  • Severity: Low

  • Step where error happened: Deploy

Current Behavior

SAT incremental tests are disable for now because of this error: '<=' not supported between instances of 'int' and 'str'

Expected Behavior

SAT incremental tests should work properly. I suggest to take this issue after a #5114 (or as the part of #5114)

Steps to Reproduce

  1. Setup the Hubspot connector
  2. Uncomment incremental tests section in acceptance-test-config.yml
  3. Run acceptance tests

Are you willing to submit a PR?

Remove this with your answer.

@vitaliizazmic
Copy link
Contributor

Data type mismatch in state was fixed in the PR #8699. Also incremental test was uncommented and implemented supporting of increment sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants