Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT not works correctly on records with nested structure and different orders #7487

Closed
avida opened this issue Oct 29, 2021 · 0 comments · Fixed by #7491
Closed

SAT not works correctly on records with nested structure and different orders #7487

avida opened this issue Oct 29, 2021 · 0 comments · Fixed by #7491
Assignees
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# type/bug Something isn't working

Comments

@avida
Copy link
Contributor

avida commented Oct 29, 2021

As @koji-m mentioned in his PR #6975 SAT thinks that objects with nested structure with list that has same elements with different orders e.g.

{
  "organization": {
    "features": [
      "performance-tag-page",
      "issue-percent-filters",
    ]
   }
}

and

  "organization": {
    "features": [
     "issue-percent-filters",
     "performance-tag-page",
     ]
   }
}

are different objects (which is not ).

SAT should not fail on this type of data.

@avida avida added type/bug Something isn't working Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# labels Oct 29, 2021
@avida avida mentioned this issue Oct 29, 2021
18 tasks
@avida avida self-assigned this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant