Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail listing definitions if the format from the server is invalid #7567

Closed
jrhizor opened this issue Nov 2, 2021 · 2 comments · Fixed by #8031
Closed

don't fail listing definitions if the format from the server is invalid #7567

jrhizor opened this issue Nov 2, 2021 · 2 comments · Fixed by #8031
Assignees
Labels
priority/high High priority type/bug Something isn't working

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Nov 2, 2021

#6975 resulted in a duplicate entry resulting in the problem observed in https://airbytehq.slack.com/archives/C01MFR03D5W/p1635865547477900

No invalid input from this file should impact availability of OSS or Cloud installations of Airbyte.

@jrhizor jrhizor added type/bug Something isn't working priority/high High priority labels Nov 2, 2021
@jrhizor jrhizor added this to the Platform 2021-11-11 milestone Nov 2, 2021
@airbyte-jenny
Copy link
Contributor

Investigating the original report, it looks like #7565 was used to resolve the short-term issue by removing a duplicate source definition from airbyte-config/init/src/main/resources/seed/source_definitions.yaml

This error caused a crash on the onboarding page, at AirbyteRequestService.ts:75 saying there were multiple definitions; this is just a wrapper on making some request to the backend (not entirely obvious which one). We should be able to reproduce by duplicating a definition locally for testing.

@airbyte-jenny
Copy link
Contributor

Modify getLatestSources() and getLatestDefinitions() to catch Throwable. Look for NoInternet test cases and modify that test case file to include formatting problems and json deserialization problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high High priority type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants