Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete_oauth_flow is called twice for google ads #7650

Closed
sherifnada opened this issue Nov 4, 2021 · 4 comments · Fixed by #8054
Closed

complete_oauth_flow is called twice for google ads #7650

sherifnada opened this issue Nov 4, 2021 · 4 comments · Fixed by #8054
Assignees
Labels
area/connectors Connector related issues type/bug Something isn't working

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

We seem to be making two calls to complete_oauth_flow once we receive an auth code from google, which makes the UI not show any visual success clues.

The issue is demonstrated in this video: https://www.loom.com/share/6da17af4728c49258871f925c70c5aa1

It's worth noting that creating the source works (the refresh token seems to be retained correctly) but

Describe the solution you’d like

we should make only one API call, and show a visual cue that it succeeded.

@sherifnada sherifnada added type/bug Something isn't working area/frontend labels Nov 4, 2021
@sherifnada
Copy link
Contributor Author

assigning to @jrhizor for triage

@sherifnada
Copy link
Contributor Author

also confirmed this happening for salesforce

@sherifnada sherifnada added the area/connectors Connector related issues label Nov 15, 2021
@tuliren
Copy link
Contributor

tuliren commented Nov 16, 2021

This is also happening for Github:

Screen Shot 2021-11-16 at 15 31 09

@tuliren
Copy link
Contributor

tuliren commented Nov 17, 2021

@ChristopheDuong, FYI the frontend is fixed now. We need to deploy cloud to pick up this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants