Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Postgres: money type fails when amount is > 1000 #7870

Closed
yurii-bidiuk opened this issue Nov 11, 2021 · 0 comments · Fixed by #7995
Closed

Source Postgres: money type fails when amount is > 1000 #7870

yurii-bidiuk opened this issue Nov 11, 2021 · 0 comments · Fixed by #7995
Assignees
@yurii-bidiuk
Labels
area/connectors Connector related issues area/databases connectors/source/postgres connectors/sources-database gl type/bug Something isn't working

Comments

@yurii-bidiuk
Copy link
Contributor

Current Behavior

The money type fails when the amount is > 1000. The reason is that in JDBC implementation money type is tried to get as Double (JDBC implementation). Max values for Money type: "-92233720368547758.08", "92233720368547758.07"

Expected Behavior

The connector should recognize all possible values for money type: from 92233720368547758.08 to 92233720368547758.07

Steps to Reproduce

  1. Go to PostresSourceDatatypeTest.class line: 333
  2. Set any value that is more than 1000
  3. Run tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurii-bidiuk yurii-bidiuk

Labels
area/connectors Connector related issues area/databases connectors/source/postgres connectors/sources-database gl type/bug Something isn't working
Projects
GL Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Source postgres: fix money type with amount > 1000 airbytehq/airbyte
3 participants
@sherifnada @yurii-bidiuk @igrankova