Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery/BigQuery denormalized Destination : Integration test enhancement for destination-bigquery-denormalized data and schemas #8870

Closed
mkhokh-33 opened this issue Dec 17, 2021 · 0 comments · Fixed by #11454
Closed

BigQuery/BigQuery denormalized Destination : Integration test enhancement for destination-bigquery-denormalized data and schemas #8870

mkhokh-33 opened this issue Dec 17, 2021 · 0 comments · Fixed by #11454
Assignees
@etsybaev
Labels
area/connectors Connector related issues connectors/destination/bigquery-denormalized connectors/destinations-warehouse type/enhancement New feature or request

Comments

@mkhokh-33
Copy link
Contributor

Tell us about the problem you're trying to solve

Currently all schemas and data for BigQueryDenormalizedDestinationTest are taken from
BigQueryDenormalizedTestDataUtils as json string which seems to be difficult to support and change.
[...]

Describe the solution you’d like

Move all schemas and data into resources folder and make changes into BigQueryDenormalizedTestDataUtils in order to read json data from resources
@mkhokh-33 mkhokh-33 added type/enhancement New feature or request needs-triage labels Dec 17, 2021
@mkhokh-33 mkhokh-33 self-assigned this Dec 17, 2021
@DoNotPanicUA DoNotPanicUA changed the title Integration test enhancement for destination-bigquery-denormalized data and schemas BigQuery/BigQuery denormalized Destination : Integration test enhancement for destination-bigquery-denormalized data and schemas Dec 17, 2021
@DoNotPanicUA DoNotPanicUA mentioned this issue Dec 17, 2021
Merged
@sherifnada sherifnada added area/connectors Connector related issues and removed needs-triage labels Dec 22, 2021
@alexandr-shegeda alexandr-shegeda mentioned this issue Feb 17, 2022
Closed
10 tasks
@etsybaev etsybaev self-assigned this Mar 20, 2022
@etsybaev etsybaev linked a pull request Mar 27, 2022 that will close this issue
🎉BigQuery denormalized Destination: Integration test enhancement for picking test-data and schemas #11454
Merged
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etsybaev etsybaev

Labels
area/connectors Connector related issues connectors/destination/bigquery-denormalized connectors/destinations-warehouse type/enhancement New feature or request
Projects
GL Roadmap
Archived in project
Milestone
No milestone
4 participants
@etsybaev @sherifnada @karinakuz @mkhokh-33