Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake copy destinations should execute COPY commands in parallel #9087

Closed
edgao opened this issue Dec 23, 2021 · 2 comments · Fixed by #10212
Closed

Snowflake copy destinations should execute COPY commands in parallel #9087

edgao opened this issue Dec 23, 2021 · 2 comments · Fixed by #10212

Comments

@edgao
Copy link
Contributor

edgao commented Dec 23, 2021

blocked on #8820

Tell us about the problem you're trying to solve

Currently, destination-snowflake's copy modes will generate multiple files on S3 or GCS, and then for each of those files, execute a COPY command in serial. We should run those commands in parallel to be more time-efficient.

Additionally, the COPY command can actually accept up to 1,000 files. destination-snowflake should take advantage of that capability.

Describe the solution you’d like

Describe the alternative you’ve considered or used

Additional context

Are you willing to submit a PR?

👍 😺

@edgao edgao added type/enhancement New feature or request needs-triage labels Dec 23, 2021
@sherifnada sherifnada added area/connectors Connector related issues and removed needs-triage labels Dec 24, 2021
@joshuataylor
Copy link

That'd be great, but there should also be a configuration set for max size of tmp directory, in case the download of source is faster than the upload to Snowflake. This way the disk doesn't fill up with tmp files whilst uploading to SF if the outbound connection speed is congested.

@edgao
Copy link
Contributor Author

edgao commented Dec 27, 2021

ooh, yeah that's a great idea! Could you make a separate issue to track that? I suspect it would be a bit separate from the features in this one

also, to double-check - you're referring to the internal staging mode? The S3 and GCS staging methods shouldn't (?) run into disk size limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants