Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_requirements.sh to build process #9231

Closed
noahkawasakigoogle opened this issue Dec 30, 2021 · 0 comments
Closed

Add check_requirements.sh to build process #9231

noahkawasakigoogle opened this issue Dec 30, 2021 · 0 comments
Labels

Comments

@noahkawasakigoogle
Copy link
Contributor

Tell us about the problem you're trying to solve

The script tools/bin/check_requirements.sh should be added as a github check in CI, this way any unexpected or unintentional changes in the version of a dependency will be caught in tests and blocked from merged.

Describe the solution you’d like

Just adding this script as a step in all jobs, or as its own job. It could be source'd in any script to do this, or put into a separate github workflow job.

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

#3028 (comment)

Are you willing to submit a PR?

Yes

@alafanechere alafanechere added area/developer Everything related to build, developer UX and removed needs-triage labels Jan 3, 2022
@bleonard bleonard added autoteam team/tse Technical Support Engineers labels Apr 26, 2022
@marcosmarxm marcosmarxm added area/platform-oss team/platform-move and removed team/tse Technical Support Engineers labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants