Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source Delighted: incorrect pagination handling in survey_responses, bounces and unsubscribes streams #9271

Closed
Zirochkaa opened this issue Jan 4, 2022 · 1 comment 路 Fixed by #9275

Comments

@Zirochkaa
Copy link
Contributor

Subtask for #8906.

Current Behavior

read command only outputs 100 records for survey_responses, bounces and unsubscribes streams.

Expected Behavior

All records should be read.

Steps to Reproduce

  1. Create 100+ records for one of survey_responses, bounces or unsubscribes streams;
  2. Run read command for that stream;
  3. See that only 100 records are read.

Are you willing to submit a PR?

Yes.

@Zirochkaa
Copy link
Contributor Author

Scoping

Right now pagination handling for survey_responses, bounces and unsubscribes streams works incorrectly.
Current implementation is the following: if we got Link response header then we need to extract page_info parameter from it and send it in the next request. If there is no Link response header then all data was read. This behavior works only for people stream.
For survey_responses, bounces and unsubscribes streams pagination handling should be following: send page parameter with number of page in it (like, page=1, page=10 etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment