Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sponsored_products_report_stream does not return adId despite it being added automatically by amazon #11659

Closed
agroh1 opened this issue Apr 1, 2022 · 2 comments
Labels
autoteam community team/tse Technical Support Engineers type/bug Something isn't working

Comments

@agroh1
Copy link
Contributor

agroh1 commented Apr 1, 2022

Environment

  • Airbyte version: example is 0.35.12-alpha

  • OS Version / Instance: macOS

  • Deployment: Docker

  • Source Connector and version: Amazon Ads 0.1.3

  • Severity: Medium

  • Step where error happened: Sync Job

Current Behavior

sponsored_products_report_stream does not return adId

Expected Behavior

adId should be returned for the productAds and asins report. It is added automatically by Amazon to the report
See the amazon documentation in this link for the metrics list. https://advertising.amazon.com/API/docs/en-us/concepts/reporting/report-types#product-ad-reports

The problem is that while adId is automatically added and returned, if adId is request the amazon api generates an error. So the connector needs to handle adId without requesting it be returned from amazon (this does seem like an amazon bug)

This adId is pretty important to actually use this report data when you need to break down by adId

Steps to Reproduce

  1. Create a source connector and connection to amazon ads
  2. See that adId is missing from sponsored_products_report_stream

Are you willing to submit a PR?

I will be submitting a PR with a fix for this

@grubberr
Copy link
Contributor

grubberr commented May 8, 2022

Can we close this ?
I see it's merged
#11660

@agroh1
Copy link
Contributor Author

agroh1 commented May 9, 2022

Yes, I think it can be closed. It is working for me in the newest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoteam community team/tse Technical Support Engineers type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants