New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source RD Station Marketing: migrated to advancedOAuth #28009
🎉 Source RD Station Marketing: migrated to advancedOAuth #28009
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-rd-station-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-rd-station-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-rd-station-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-rd-station-marketing test
source-rd-station-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-rd-station-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-rd-station-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-rd-station-marketing test
/approve-and-merge reason="testing blocked by test creds, source is disabled on cloud, this part of code was never used" |
What
resolved: #27974
How
Removed deprecated authSpecification, switched to advanced_auth
Note
Acceptance test are blocked by test creds. This connector is disabled on cloud, so this part of code was not used. So PR can be merged without passed tests (slack thread)