Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source RD Station Marketing: migrated to advancedOAuth #28009

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Jul 6, 2023

What

resolved: #27974

How

Removed deprecated authSpecification, switched to advanced_auth

Note

Acceptance test are blocked by test creds. This connector is disabled on cloud, so this part of code was not used. So PR can be merged without passed tests (slack thread)

@darynaishchenko darynaishchenko self-assigned this Jul 6, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 6, 2023
@darynaishchenko darynaishchenko changed the title Source RD Station Marketing: migrated to advancedOAuth 🎉 Source RD Station Marketing: migrated to advancedOAuth Jul 6, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-rd-station-marketing test report (commit ec72c6da65) - ❌

⏲️ Total pipeline duration: 02mn41s

Step Result
Validate airbyte-integrations/connectors/source-rd-station-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-rd-station-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-rd-station-marketing test

@octavia-squidington-iii
Copy link
Collaborator

source-rd-station-marketing test report (commit ec72c6da65) - ❌

⏲️ Total pipeline duration: 02mn40s

Step Result
Validate airbyte-integrations/connectors/source-rd-station-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-rd-station-marketing docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-rd-station-marketing test

@darynaishchenko
Copy link
Collaborator Author

/approve-and-merge reason="testing blocked by test creds, source is disabled on cloud, this part of code was never used"

@octavia-approvington
Copy link
Contributor

You did it!
finish line

@octavia-approvington octavia-approvington merged commit 845b771 into master Jul 7, 2023
20 of 26 checks passed
@octavia-approvington octavia-approvington deleted the daryna/source-rd-station-marketing/migrate-to-advancedAuth branch July 7, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/rd-station-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source RD Station Marketing: Migrate to advancedAuth
4 participants