New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Stripe: have all full_refresh stream syncs be concurrent #32473
✨ Source Stripe: have all full_refresh stream syncs be concurrent #32473
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@@ -38,15 +40,11 @@ | |||
|
|||
|
|||
class SourceStripe(AbstractSource): | |||
def __init__(self, catalog_path: Optional[str] = None, **kwargs): | |||
def __init__(self, catalog: ConfiguredAirbyteCatalog, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was like this before but this interface feels weird as I would expect:
source = SourceStripe(<a catalog with only one stream>
streams = source.streams()
assert len(streams) == 1
However, all streams are returned there. I guess otherwise would be a breaking change as streams has always returned everything. There are also cases where we don't have the catalog (for example, discover
)
EDIT: would it help if we change the naming to concurrent_full_refresh_catalog
? It seems very weird but many it's more aligned with what it does...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great!
What
Addresses #32308
How
Creating a set of all stream names that are full refresh from the catalog and if a stream name is within this set, create a stream using StreamFacade instead
Notes
There is an acceptance criteria that mentions
Verify that the streams that do not have CAT coverage still work as expected
. However I could not test some of those streams because:Streams I could not test:
Note that testing for early_fraud_warnings yielded only one record.