Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Stripe: have all full_refresh stream syncs be concurrent #32473

Merged

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Nov 13, 2023

What

Addresses #32308

How

Creating a set of all stream names that are full refresh from the catalog and if a stream name is within this set, create a stream using StreamFacade instead

Notes

There is an acceptance criteria that mentions Verify that the streams that do not have CAT coverage still work as expected. However I could not test some of those streams because:

  • Could not find streams with records in the last 7 days
  • Stream name was shared with other sources and I timeboxeds manually mapping from log to a stripe sync with records after 5 minutes for each stream

Streams I could not test:

  • application_fees_refunds
  • authorizations
  • external_account_cards
  • payment_methods
  • persons
  • reviews
  • transactions

Note that testing for early_fraud_warnings yielded only one record.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 2:32am

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@@ -38,15 +40,11 @@


class SourceStripe(AbstractSource):
def __init__(self, catalog_path: Optional[str] = None, **kwargs):
def __init__(self, catalog: ConfiguredAirbyteCatalog, **kwargs):
Copy link
Contributor Author

@maxi297 maxi297 Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was like this before but this interface feels weird as I would expect:

source = SourceStripe(<a catalog with only one stream>
streams = source.streams()
assert len(streams) == 1

However, all streams are returned there. I guess otherwise would be a breaking change as streams has always returned everything. There are also cases where we don't have the catalog (for example, discover)

EDIT: would it help if we change the naming to concurrent_full_refresh_catalog? It seems very weird but many it's more aligned with what it does...

@maxi297 maxi297 changed the title [ISSUE #32308] stripe stream concurrent when sync mode full refresh ✨ Source Stripe: have all full_refresh stream syncs be concurrent Nov 13, 2023
@maxi297 maxi297 marked this pull request as ready for review November 14, 2023 02:09
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 14, 2023 02:11
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! :shipit:

@maxi297 maxi297 merged commit 93bc6f1 into master Nov 14, 2023
25 of 26 checks passed
@maxi297 maxi297 deleted the issue-32308/stripe-concurrent-when-stream-is-full-refresh branch November 14, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants