New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper Packaging with fastai requirement #222
Comments
@oke-aditya I saw your previous comments here: "That means in Kaggle competitions dataset. Upload fastai v2, PyTorch lightning wheels, install them then try to install mantisshrimp." Datasets details: https://www.kaggle.com/kaushal2896/pycocotools |
Can it be fixed within 1 or 2 days from now?. Only 9 days are remaining. |
We can fix it ASAP, can you share your kernel !!. @lgvaz and I can fix it up and hand over kernel to you. |
@rashmimarganiatgithub As I said in #214 , we do need a reproducer for the error, or else it's going to be very hard for us to fix the issue |
In order share the kernel you should be part of the team. Hence it is against the rules to share with other, so I have downloaded the code and shared you in google colab and will share the Kaggle dataset which I am using as the reference to fix it. |
@oke-aditya I have updated the comment with datasets. Hope it helps you to reproduce the bug easily. |
@lgvaz we need to have a look. |
@oke-aditya any improvement on this? |
@rashmimarganiatgithub |
I updated the dependencies so you don't need to install pytorch-lightning If I understood your problem correctly, you only need to do predictions offline, if that's the case, you don't need to install fastai, just fastcore will suffice. In your notebooks you were doing: from mantisshrimp.models.rcnn.faster_rcnn import *
from mantisshrimp.models.rcnn import * That can cause problems with our soft-dependencies, the correct way of importing is: from mantisshrimp.models.rcnn import faster_rcnn Here is a minimal installation notebooks, I hosted the wheel used there here Please tell us if everything is working now =) |
@lgvaz @oke-aditya it is working... thanks much.. |
Re opened from #214
@rashmimarganiatgithub
cc @lgvaz
Let's solve this here. So that other people too can benefit if they face this.
We are trying to package our code properly for deployment still. #217.
@lgvaz This improper packaging is a concern. #181 problem.
Really sorry @rashmimarganiatgithub this package is still preparing for its first release 0.1 and we yet need to fix such issues.
The text was updated successfully, but these errors were encountered: