Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pgbouncer.authType value to set auth_type (for Azure PostgreSQL) #419

Closed
thesuperzapper opened this issue Sep 6, 2021 · 0 comments · Fixed by #498
Closed

add pgbouncer.authType value to set auth_type (for Azure PostgreSQL) #419

thesuperzapper opened this issue Sep 6, 2021 · 0 comments · Fixed by #498
Labels
kind/enhancement kind - new features or changes
Projects
Issue Triage and PR Tracking
Milestone
airflow-8.6.0

Comments

@thesuperzapper
Copy link
Member

Currently, we hard-code auth_type in pgbouncer.ini to md5.

While auth_type = md5 is a sensible default (as versions of Postgres before 10 don't support scram-sha-256), some providers have disabled support for md5 authentication (like Azure PostgreSQL), which has led to issues like:

We should allow users to set their own auth_type in pgbouncer.ini by creating a new value called pgbouncer.authType (with md5 as a default).
@thesuperzapper thesuperzapper added the kind/enhancement kind - new features or changes label Sep 6, 2021
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Sep 6, 2021
@thesuperzapper thesuperzapper moved this from Unsorted to To Do | priority-p1 in Issue Triage and PR Tracking Sep 6, 2021
@thesuperzapper thesuperzapper mentioned this issue Sep 6, 2021
Closed
@stale stale bot added lifecycle/stale lifecycle - this is stale and removed lifecycle/stale lifecycle - this is stale labels Nov 5, 2021
@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Dec 14, 2021
@thesuperzapper thesuperzapper moved this from To Do | priority-p1 to Working On | Mathew in Issue Triage and PR Tracking Dec 14, 2021
@thesuperzapper thesuperzapper mentioned this issue Jan 10, 2022
Merged
6 tasks
@thesuperzapper thesuperzapper moved this from PR | Needed to PR | Ready to Merge in Issue Triage and PR Tracking Jan 11, 2022
@stale stale bot added the lifecycle/stale lifecycle - this is stale label Feb 13, 2022
@stale stale bot closed this as completed Feb 20, 2022
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Feb 20, 2022
Issue Triage and PR Tracking automation moved this from Done to Unsorted Feb 22, 2022
@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Feb 22, 2022
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Feb 22, 2022
@thesuperzapper thesuperzapper moved this from PR | Ready to Merge to Triage | PR Created in Issue Triage and PR Tracking Mar 2, 2022
@thesuperzapper thesuperzapper changed the title add pgbouncer.authType value to set auth_type add pgbouncer.authType value to set auth_type (for Azure PostgreSQL) Mar 22, 2022
@airflow-helm airflow-helm deleted a comment from stale bot Mar 22, 2022
@airflow-helm airflow-helm deleted a comment from stale bot Mar 22, 2022
Issue Triage and PR Tracking automation moved this from Triage | Work Started to Done Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement kind - new features or changes
Projects
Issue Triage and PR Tracking
Done
Milestone
airflow-8.6.0
Development

Successfully merging a pull request may close this issue.

feat: add pgbouncer.authType value thesuperzapper/charts
1 participant
@thesuperzapper