Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allocations for addressing modes and instructions #10

Closed
airloaf opened this issue Jul 15, 2020 · 0 comments
Closed

Remove allocations for addressing modes and instructions #10

airloaf opened this issue Jul 15, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
First Release (1.0)

Comments

@airloaf
Copy link
Owner

airloaf commented Jul 15, 2020

The CPU is very sluggish when running it on VNES. I can imagine it has to do with all the allocations that come into play when creating a new instruction as well as addressing modes. I think the best move will be to move the addressing mode functionality within the instruction class and we should only allocate a single instruction object and re-use it constantly. This should improve the CPU's performance greatly.
@airloaf airloaf added the enhancement New feature or request label Jul 15, 2020
@airloaf airloaf added this to the First Release (1.0) milestone Jul 15, 2020
airloaf added a commit that referenced this issue Jul 16, 2020
@airloaf
No longer allocating addressing modes #10.
522165e
airloaf added a commit that referenced this issue Jul 16, 2020
@airloaf
Removed all addressing mode classes from codebase #10.
5413216
airloaf added a commit that referenced this issue Jul 16, 2020
@airloaf
Removed the allocation of the Instruction object #10.
b4c1a8c
@airloaf airloaf closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
First Release (1.0)
Development

No branches or pull requests
1 participant
@airloaf