Agree on canonical frontend code

[spatiebot]

@congratulatio and @spatiebot in an unrelated thread:

we should appoint one frontend repository as the canonical frontend. We could take the one from airmash-refugees, but, @wight-airmash, you may have a better one somewhere lying around?

airmash.online is currently using the frontend code at congratulation/ao-frontend.
I could integrate the changes from airmash-refugees/airmash-frontend to make it easier to hack on if that helps?

@congratulatio, please feel free to merge the repositories and anoint one of them as canonical. If I can help, I'll be glad to do so.

[spatiebot]

@congratulatio <--

[congratulatio]

Thanks Spatie, I will have a look at it this weekend. Looks they haven't diverged much except on increased readability? So hoping it will be a straightforward task - will let you know if I need any help figuring it out!

[congratulatio]

I've pushed the changes I made to make this functionally identical to congratulation/ao-frontend.

https://test.airmash.online is now running the latest commit of airmash-refugees/airmash-frontend. Would you mind looking over my changes and reviewing the test site to check I haven't broken anything?

[spatiebot]

I looked at the changes, they look good at first glance. The fetch API is the most risky change, I think, but if it improves the code, it's good.

The test site doesn't work on my linux/firefox installation:
Particles.setup is not a function

It does work on my Windows/Firefox setup. Also the regular airmash.online does work on the Linux/Firefox combination.

[spatiebot]

It may have been my adblocker. Disabling it and it works. I'm closing this issue.

[congratulatio]

I think the Fetch API change is okay, it's been on the current airmash.online frontend since congratulatio/ao-frontend@ef54a3c, and from monitoring the /clienterror endpoint I haven't seen anything reported that seems to relate to it.

Could you share more details on your adblocker and the rule that was activated? Maybe one or more of the JavaScript files will need to be renamed to avoid this. Or perhaps could bundle and minify it all for deployment like the original site.

[congratulatio]

Could you share more details on your adblocker and the rule that was activated? Maybe one or more of the JavaScript files will need to be renamed to avoid this. Or perhaps could bundle and minify it all for deployment like the original site.

@spatiebot in case you didn't see this comment as the issue is closed

[spatiebot]

I'll try later.

[congratulatio]

This is done, now only the frontend code in this repo is served from airmash.online.

https://test.airmash.online is automatically deployed from the latest commit of master branch.

https://airmash.online is deployed manually from tag airmash.online-current (link).