Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicating release dates to NCBI in CEDAR metadata #143

Closed
graybeal opened this issue Jul 25, 2018 · 3 comments
Closed

indicating release dates to NCBI in CEDAR metadata #143

graybeal opened this issue Jul 25, 2018 · 3 comments

Comments

@graybeal
Copy link
Contributor

In the CEDAR template there is only one field to indicate "Expected Release Date", and it has no impact on whether the submission is made public or not. I'm not sure what its purpose is (any thoughts?).

There are 2-3 different submission types created by the template: BioProject (if it doesn't already exist); BioSample; and SRA. The latter 2 can each have multiple instances.

NCBI interpretation of release dates is complicated; they release 'parent' items like BioProject if the (any!) BioSample or SRA submission is released.

For simplicity we propose a optional single release date for the whole CEDAR collection, which may include any number of BioSample or SRA submissions. The release date field would be at the top of the template.

Is this agreeable?

If not, we could add release dates to each section, but we would not add code to check that no unexpected consequence will ensue. (We can document the understood behavior in the help text for each release date though.

@frubelt
Copy link

frubelt commented Jul 25, 2018 via email

@bussec
Copy link
Member

bussec commented Jul 26, 2018

Yes, I agree this is the best solution as the outcome of setting the release date will be obvious to everyone.

@graybeal
Copy link
Contributor Author

OK, we will implement it as I proposed. I believe (based on testing) we can just change add that field to the current template and the (two or three) existing in-progress instances will pick up the changes gracefully.

We also will change the documentation of the existing Expected Release Data attribute in the BioSample part to make clear that is not used for setting any of the release dates in NCBI.

@bussec bussec closed this as completed Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants