Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make airshipconfig and kubeconfig file modifications co-dependent #25

Closed
ianpittwood opened this issue Feb 10, 2020 · 2 comments
Closed

Make airshipconfig and kubeconfig file modifications co-dependent #25

ianpittwood opened this issue Feb 10, 2020 · 2 comments
Labels
3-Container Relates to plugin related issues enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right

Comments

@ianpittwood
Copy link
Contributor

Problem description (if applicable)
Writing to the airshipconfig and kubeconfig in PersistConfig() can result in modifications to only the airshipconfig file if an error occurs. This will result in differences between the airshipconfig and kubeconfig.

Proposed change
A possible solution is to make the modifications to each file codependent. A backup of each file could be created before modifications are made and restored if an error occurs.

Source: FIXME(howell), pkg/config/config.go, L355-359
@ianpittwood ianpittwood added enhancement New feature or request 3-Container Relates to plugin related issues labels Feb 10, 2020
@ansumanbebarta
Copy link

I was checking the issue and found that the below source is no longer there.
Source: FIXME(howell), pkg/config/config.go, L355-359
I could find the commit which modified the FIXME.

32ef584#diff-091ace02b49a46f55f2586cfec89a160L355

@jezogwza jezogwza added the triage Needs evaluation by project members label Mar 4, 2020
@drewwalters96 drewwalters96 added the good first issue Good for newcomers label Mar 9, 2020
@ianpittwood ianpittwood added the invalid This doesn't seem right label Mar 9, 2020
@ianpittwood
Copy link
Contributor Author

It seems that this was already fixed based on @ansumanbebarta 's comment

@ianpittwood ianpittwood removed the triage Needs evaluation by project members label Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3-Container Relates to plugin related issues enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ansumanbebarta @jezogwza @drewwalters96 @ianpittwood