Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airshipctl and clusterctl integration #29

Closed
alanmeadows opened this issue Feb 10, 2020 · 1 comment
Closed

airshipctl and clusterctl integration #29

alanmeadows opened this issue Feb 10, 2020 · 1 comment
Labels
2-Manifests Relates to manifest/document set related issues enhancement New feature or request priority/medium Default priority for items
Projects
Milestone

Comments

@alanmeadows
Copy link
Contributor

alanmeadows commented Feb 10, 2020

Problem description (if applicable)
For both ephemeral and target invokations of airshipctl cluster initinfra as well as a non-existent pivot command we intend to integrate the clusterctl pkg as a library.

While the clusterctl pkg continues to develop, this issue represents the effort of beginning that integration to understand the specific gaps remaining, especially the work we need to accomplish upstream within clusterctl.

Proposed change
For the airshipctl cluster initinfra commands, leverage the clusterctl library to perform the init, effectively equivalent to a clusterctl init. This will initially be equivalent to a kubectl apply of the provider resources, and we will build on the gaps remaining for leveraging metal3-io as a provider to just providing that - for instance, ensuring that the baremetal-operator, ironic, and so on are also instantiated, as well as BareMetalHost records to support subsequent Machine provisioning.

Within airshipctl, there is a need to be able to feed provider resources to a library like clusterctl. There has been work done upstream in clusterctl to support pulling provider resources from a local file system. We need to understand whether this will work for the way airshipctl renders documents through Kustomize and emits them as Document objects as part of a bundle - see the following pull request in clusterctl. Will we create a fake filesystem and provide that to clusterctl or enhance it upstream to support a YAML byte stream?

Potential impacts
There may be requirements for clusterctl upstream that may need to be solved locally in airshipctl.

@alanmeadows alanmeadows added the enhancement New feature or request label Feb 10, 2020
@alanmeadows alanmeadows changed the title Airshipctl and Clusterctl Integration airshipctl and clusterctl Integration Feb 10, 2020
@alanmeadows alanmeadows changed the title airshipctl and clusterctl Integration airshipctl and clusterctl integration Feb 10, 2020
@alanmeadows alanmeadows added the 2-Manifests Relates to manifest/document set related issues label Feb 10, 2020
@jezogwza jezogwza added triage Needs evaluation by project members priority/medium Default priority for items and removed triage Needs evaluation by project members labels Mar 4, 2020
@jezogwza jezogwza added this to To do in Airship 2.0 via automation Mar 11, 2020
@jezogwza jezogwza added this to the betav1 milestone Mar 11, 2020
@jezogwza
Copy link
Contributor

Already there are separate issue closed or in progress for integrating clusterctl init and clusterctl move.

Airship 2.0 automation moved this from To do to Done May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Manifests Relates to manifest/document set related issues enhancement New feature or request priority/medium Default priority for items
Projects
Airship 2.0
  
Done
Development

No branches or pull requests

2 participants