Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check try..catch exception variable name #5

Open
eharris opened this issue Oct 10, 2019 · 2 comments
Open

Check try..catch exception variable name #5

eharris opened this issue Oct 10, 2019 · 2 comments

Comments

@eharris
Copy link

eharris commented Oct 10, 2019

I'm not sure this really matters enough to be worth it, so posing as a question. Do we want to try to keep try..catch exception variable names consistent?

In the current master head (excluding javascript), there are:

  • 105 uses of x
  • 87 uses of e
  • 3 uses of ignored (I think this one should still be allowed)
  • 2 uses of failed (I dislike this one a lot)
  • 1 use of ex

The two top use cases are fairly even, so if we do want to do this, I'm fine with deciding on either one (I usually tend to use e myself)

The javascript seems to all use e or ex.

@jvoisin
Copy link

jvoisin commented Oct 10, 2019

My vote goes to e, but it's really minor.

@muff1nman
Copy link
Contributor

Doesn't bother me as long as we can keep ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants