Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: Fix windows wheels #1383

Closed
HaoZeke opened this issue Feb 12, 2024 · 6 comments
Closed

REL: Fix windows wheels #1383

HaoZeke opened this issue Feb 12, 2024 · 6 comments
Milestone

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Feb 12, 2024

Run pypa/cibuildwheel@v2.15.0
Run actions/setup-python@v4
Installed versions
Run pipx run --python "C:\hostedtoolcache\windows\Python\3.11.7\x64\python.exe" --spec "D:\a\_actions\pypa\cibuildwheel\v2.15.0" cibuildwheel "." --output-dir '"wheelhouse"' --config-file '""' --only '""'
Invalid --only='""', must be a build selector with a known platform
creating virtual environment...
creating virtual environment...
determining package name from 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.15.0'...
installing cibuildwheel from spec 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.15.0'...
Error: Process completed with exit code 1.

..

@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 12, 2024

Maybe for the next release

@HaoZeke HaoZeke added this to the 0.6.3 milestone Feb 12, 2024
@mattip
Copy link
Contributor

mattip commented Feb 12, 2024

I was seeing this in the scipy builds as well. I am trying an update to cibuildwheel’s version

@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 12, 2024

I was seeing this in the scipy builds as well. I am trying an update to cibuildwheel’s version

Awesome, then in that case since it seems to be something which might be fixed in the near future I'll just delete the tag and wait to get it in 0.6.2 (luckily didn't publish to PyPI yet)

@HaoZeke HaoZeke modified the milestones: 0.6.3, 0.6.2 Feb 12, 2024
@mattip
Copy link
Contributor

mattip commented Feb 12, 2024

According to pypa/cibuildwheel#1748, this is fixed in cibuildwheel 2.16.5.

@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 12, 2024

According to pypa/cibuildwheel#1748, this is fixed in cibuildwheel 2.16.5.

Yup, I think it should work, have a run now: https://github.com/airspeed-velocity/asv/actions/runs/7870830392

I thought upgrading to v4 for upload-artifact and download-artifact would be a good idea but it needs some migration actions/upload-artifact#478 (hence the new run).

@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 12, 2024

Done! Release is live too, downloaded the artifacts from the run and used twine upload to put them on PyPI.

Also on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants