Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add K8S probes checker API #1181

Open
4 tasks
Lancetnik opened this issue Jan 29, 2024 · 2 comments
Open
4 tasks

Feature: add K8S probes checker API #1181

Lancetnik opened this issue Jan 29, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Lancetnik
Copy link
Collaborator

Lancetnik commented Jan 29, 2024

We should provides users with an ability to check application health in a some way. It can be reached by using multiple mechanism, so we can create a base Checker Protocol and use it the following way

app = FastStream(broker)
app.add_checker(
     SocketChecker("/sock"),
     # HTTPChecker(port=8000),
     # ...
)

And check all of them by the same command

faststream probe main:app

So, we can create multiple checkers for various cases and user can implement any checker by itself in the same time

  • add broker.ping() unified method
  • add BaseCheker using broker.ping()
  • implement HTTPChecker (inheritor of BaseCheker)
  • add CLI command to use any checker
@Lancetnik Lancetnik added enhancement New feature or request good first issue Good for newcomers labels Jan 29, 2024
@Lancetnik
Copy link
Collaborator Author

Lancetnik commented Mar 9, 2024

Assigned to @Sehat1137

@danb27
Copy link

danb27 commented Apr 2, 2024

I would love this feature! +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants