Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transaction in AioKafkaFastProducer #1290

Closed
wants to merge 4 commits into from
Closed

feat: add transaction in AioKafkaFastProducer #1290

wants to merge 4 commits into from

Conversation

spataphore1337
Copy link
Contributor

@spataphore1337 spataphore1337 commented Mar 7, 2024 •
edited

Description

The ability to use Kafka transactions by the AioKafkaFastProducer object using an out-of-the-box implementation in aiokafka has been added. Previously published an issue with a request to add such functionality to Faststream.

Fixes #1237

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@davorrunje
Copy link
Collaborator

@spataphore1337 thank you for the contribution! Would you be able to add a simple test and a page in the documentation explaining how to use it?

@davorrunje davorrunje self-requested a review March 11, 2024 09:42
@spataphore1337 spataphore1337 changed the title fead: add transaction in AioKafkaFastProducer feat: add transaction in AioKafkaFastProducer Mar 11, 2024
@spataphore1337
Copy link
Contributor Author

spataphore1337 commented Mar 11, 2024 •
edited

@spataphore1337 thank you for the contribution! Would you be able to add a simple test and a page in the documentation explaining how to use it?

I had a chat with @Lancetnik and we came to the conclusion that it's best to hold off on adding transactions from aiokafka for now. The thing is, as it turned out, there is not the most obvious implementation there and adding simple top-level access to aiokafka methods is not enough. I don't think there's no point in demonstrating with examples yet either, but the main difference from batch publish is that with transactions we can publish posts to different topics.

@davorrunje
Copy link
Collaborator

@spataphore1337 what should we do with this PR then? Close it or something else?

@Lancetnik Lancetnik closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje Awaiting requested review from davorrunje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: adding Kafka transactions.
3 participants
@spataphore1337 @davorrunje @Lancetnik