-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade browserify #171
Comments
Just had an idea. We could finish off This way you can stay on It also enables us to postpone the decision of dropping IE9-10 support a little further. |
https://github.com/airtap/airtap/blob/master/doc/airtap.yml.md#browserify-optional Seems like doing npm install -D buffer@4 browserify:
- require: "buffer/"
expose: "buffer" would allow you to use a locally installed Buffer v4 module. With a simple workaround like that I think dropping support by default is OK. I like @ralphtheninja's suggestion too—release 1.x with browserify@13 first to reduce friction for packages that are still switching from zuul to airtap, then later they can either upgrade to airtap@2 and add the workaround to get the new browserify, or stay on airtap@1 as long as it works for them. e; Personally I'd like to support as many things as possible as long as possible, until it becomes really difficult. for many modules supporting IE9 is quite easy because it has decent ES5 support. It would be a shame to drop support for those browser versions (even if they are little used) when it's not that difficult to keep them around. Obviously for |
I like this approach very much. 👍 |
Yes! Let's do that. |
Related: I noticed that our version of watchify (~3.11.0) depends on browserify |
It shouldn't, watchify only depends on browserify for its CLI. since airtap uses watchify as a plugin instead it's fine. |
At this time, I think I prefer just dropping IE10 right away and release |
airtap is used in the IIRC browserify 13 doesn't support async functions and some other modern syntax features that are now sometimes used untranspiled in new modules, so there are real benefits to upgrading. |
Ah, cool. Can you share links to those modules?
💯 |
I see they include IE9, even. Nice to know airtap works there :) Alternatively, we can release 1.0.0 now (without the originally planned tasks, for which I personally have no capacity atm), then upgrade Airtap's API hasn't stabilized, so we might have to release a few more majors in succession, but that's fine as long as breaking changes are clearly documented. I also like @feross's argument that it's easier to identify a semver-major as having breaking changes. |
Continuing from #165 (comment):
The text was updated successfully, but these errors were encountered: