Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android 7 #235

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Fix android 7 #235

merged 2 commits into from
Dec 29, 2018

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Dec 29, 2018 •
edited

Closes airtap/browsers#3, using the workaround suggested by @jhiesey in airtap/browsers#3 (comment).

@vweevers vweevers added this to Backlog in Airtap via automation Dec 29, 2018
@vweevers vweevers changed the title Fix android 7 Fix android 7 [wip] Dec 29, 2018
vweevers added a commit to Level/level-js that referenced this pull request Dec 29, 2018
@vweevers
canary test airtap/airtap#235
ee73d20
@vweevers
Copy link
Member Author

vweevers commented Dec 29, 2018 •
edited

This works (tested with level-js on Android 6.0, 7.0, 7.1), so I'm happy. Tasks left:

  • Restore android latest in airtap-browsers
  • Backport to airtap@1 (8d1b1fa)

@vweevers vweevers changed the title Fix android 7 [wip] Fix android 7 Dec 29, 2018
@vweevers vweevers merged commit 2fe7a27 into master Dec 29, 2018
Airtap automation moved this from Backlog to Done Dec 29, 2018
@vweevers vweevers deleted the fix-android-7 branch December 29, 2018 16:10
@vweevers vweevers mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Airtap
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vweevers @ralphtheninja