Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frameworks other than tap(e) #9

Closed
vweevers opened this issue Feb 11, 2018 · 7 comments
Closed

Remove frameworks other than tap(e) #9

vweevers opened this issue Feb 11, 2018 · 7 comments
Assignees
@ralphtheninja
Projects
Airtap

Comments

@vweevers
Copy link
Member

Thumbs up?
@vweevers vweevers added the question Support or open question(s) label Feb 11, 2018
@mcollina
Copy link
Contributor

👍

@vweevers vweevers mentioned this issue Feb 13, 2018
Closed
@vweevers vweevers added this to Backlog in Airtap Feb 14, 2018
@vweevers vweevers removed the question Support or open question(s) label Feb 16, 2018
This was referenced Feb 17, 2018
Closed
Merged
@vweevers vweevers moved this from Backlog to Todo in Airtap Feb 18, 2018
@vweevers vweevers changed the title Remove frameworks other than tap(e)? Remove frameworks other than tap(e) Feb 18, 2018
@vweevers
Copy link
Member Author

I'll start looking into this, see what we need to do.

@vweevers vweevers self-assigned this Feb 18, 2018
@vweevers
Copy link
Member Author

vweevers commented Feb 18, 2018 •
edited by ralphtheninja
Loading

Tasks for multiple PRs, in order:

  • Remove test/integration/jamine-phantom.js (no added value, not worth rewriting as tape test)
  • Remove test/fixtures/jasmine/
  • Remove test/integration/mocha-qunit-phantom.js (uses same fixture as mocha-qunit-sauce test)
  • Remove test/integration/mochabdd-phantom.js (no added value)
  • Remove test/fixtures/mocha-bdd/
  • Rewrite test/integration/mocha-qunit-sauce.js and fixtures/mocha-qunit to use tape
  • Rename test/integration/mocha-qunit-sauce.js to test/integration/tape-sauce.js
  • Remove ui option from test/integration/capabilities.js (so that it defaults to tape)
  • Remove ui option from bin/airtap (and any references to it)
  • Remove exports from frameworks/index.js
  • Remove frameworks/* directories except for tape
  • Flatten the frameworks/tape directory or move it to lib
  • Remove references to emberjs example in doc/airtap.yml.md
  • Change example in doc/travis-matrix.md to use tape instead of mocha
  • Remove devDependencies (and dependency-check -i): mocha, qunit

@ralphtheninja
Copy link
Member

ralphtheninja commented Feb 19, 2018 •
edited
Loading

Also

  • Remove frameworks/tape/framework.js
  • Remove <script src="/__zuul/framework.js"></script> from frameworks/index.html

@vweevers vweevers removed their assignment Feb 20, 2018
@ralphtheninja
Copy link
Member

I'd like to take this on if no one has any objections.

@ralphtheninja ralphtheninja self-assigned this Feb 20, 2018
@ralphtheninja ralphtheninja mentioned this issue Feb 21, 2018
Merged
@ralphtheninja
Copy link
Member

ralphtheninja commented Feb 21, 2018 •
edited
Loading

@vweevers Correct me if I'm wrong, but it seems to me the end result would be

  • only one fixture, e.g. test/fixtures/tape/test.js
  • two integration tests for browsers, test/integrations/tape-phantom.js and test/integrations/tape-sauce.js using the fixture above ^

@vweevers
Copy link
Member Author

Right. It's not much.

@ralphtheninja ralphtheninja moved this from Todo to In Progress in Airtap Feb 21, 2018
This was referenced Feb 22, 2018
Merged
Merged
Merged
Merged
Merged
Airtap automation moved this from In Progress to Done Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ralphtheninja ralphtheninja

Labels
None yet
Projects
Airtap
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @ralphtheninja @vweevers