Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberStepFactories.separator returns NaN for negative numbers with three digits #19

Closed
ncote opened this issue Dec 6, 2016 · 1 comment · Fixed by #20
Closed

numberStepFactories.separator returns NaN for negative numbers with three digits #19

ncote opened this issue Dec 6, 2016 · 1 comment · Fixed by #20

Comments

@ncote
Copy link

ncote commented Dec 6, 2016

The default numberStepFactories.separator (i.e. with three-digit groupings) shows NaN for negative numbers having exactly three digits (or rather multiples of three digits).

Example:

$('#world-population').animateNumber( {
      number: -222,
      numberStep: $.animateNumber.numberStepFactories.separator(',')
      });

This will show "NaN,222" , presumably because the negative sign is left in a digit group by itself.

@aishek
Copy link
Owner

aishek commented Dec 7, 2016

Just published v0.0.14 with fixes for the issue.

@ncote kudos for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants