Better error type #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letmutx
force-pushed
the
better-error-type
branch
from
cf237d0
to
ef82bd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 55.36% 54.21% -1.16%
==========================================
Files 11 11
Lines 587 629 +42
==========================================
+ Hits 325 341 +16
- Misses 262 288 +26
Continue to review full report at Codecov.
|
|
Epic work! But sorry I'm still got busy in work. Will review it in next holiday. |
|
No hurry, take your time! |
letmutx
force-pushed
the
better-error-type
branch
from
ef82bd6
to
decb6de
Compare
|
rebased with latest master |
aisk
reviewed
Jan 3, 2020
aisk
reviewed
Jan 3, 2020
|
Merged, thank for contributions! @letmutx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
I may have gone a bit overboard refactoring the binary protocol. Sorry about that!
The issue with returning same errors in both ASCII and binary protocol is that the format of errors is different. We should instead document that the errors returned by both the protocols may be different but guarantee that the same error is returned in the future versions too for compatibility.