Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP parameters for SmartNetworkLoader #37

Closed
Floul opened this issue Aug 26, 2022 · 3 comments
Closed

HTTP parameters for SmartNetworkLoader #37

Floul opened this issue Aug 26, 2022 · 3 comments

Comments

@Floul
Copy link

Floul commented Aug 26, 2022

Sometimes it's needed to specify additional parameters for an HTTP request. In my case I need to pass an api token in the header to be able to get access to my localization service (Localizely).
Currently the loader takes String URL. I think it would be better to change it to HTTP object instead, so user can shape the request as he\she needs. Just a suggestion.
@Floul Floul mentioned this issue Aug 26, 2022
Merged
9 tasks
@Floul Floul changed the title Http parameters for SmartNetworkLoader HTTP parameters for SmartNetworkLoader Aug 26, 2022
@ariefwijaya
Copy link
Contributor

ok I'll take this @aissat

@horlannn
Copy link

@aissat pls let me know when you complete it,I need it a lot

@aissat
Copy link
Owner

aissat commented Sep 27, 2022 •
edited

done easy_localization_loader: ^1.0.1

@aissat aissat closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aissat @ariefwijaya @Floul @horlannn