Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer specific config interface #135

Closed
tkmnet opened this issue Nov 30, 2022 · 0 comments
Closed

Optimizer specific config interface #135

tkmnet opened this issue Nov 30, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tkmnet
Copy link

tkmnet commented Nov 30, 2022

Is your feature request related to a problem? Please describe.
It is related to #133. Some cases want to define optimizer-specific configs like is contained in the PR.
In the current implementation, config.py is modified when defining the specific configs in a custom optimizer. It is inconvenient.

Describe the solution you'd like
I want an interface for the specific configs in config.yml that do not need modifying config.py.

One solution is to allow optimizers responsible values in the optimize group of config. In this case, the default values are managed in an optimizer.
But, the conflict avoidance method is maybe wanted like the following implementation.
E.g.

  • Only allowing a dictionary that named to same as the optimizer name.
optimize:
  search_algorithm: "foo.barOptimizer"
  "foo.barOptimizer":
    param0: 0.0
print(config.specific.get("param0", default=0.0))
@yoshipon yoshipon added the enhancement New feature or request label Dec 12, 2022
@tkmnet tkmnet changed the title Each optimizer specific config interface Optimizer specific config interface Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants