Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal instead of Moment #1

Open
b3n4kh opened this issue Jul 22, 2022 · 1 comment
Open

Temporal instead of Moment #1

b3n4kh opened this issue Jul 22, 2022 · 1 comment
Labels
complex Complex issue requires design decissions

Comments

@b3n4kh
Copy link
Contributor

b3n4kh commented Jul 22, 2022

Currently, Koord2ool uses Moment.js for date manipulation and handling beyond JavaScript's intrinsic API.

However, TC39 has a proposal with a new Temporal class. It has not landed in production-grade ECMAScript yet, but it is likely to be included in future ECMAScript releases.

Once Temporal is live and production-ready, Moment.js should be switched out in favor of it.

Additionally chart.js which is used for visualizing charts uses moment.js for time-based x-axes.

This may require chart.js to do the switch first before we can address this.

@b3n4kh b3n4kh added the complex Complex issue requires design decissions label Sep 6, 2022
@MrManny
Copy link
Contributor

MrManny commented Sep 6, 2022

The things to watch out for to see if this feature can be integrated:

moment.js is heavily used by chart.js for time axes. So it will need to be adopted by them first before we can do the switch, which likely requires widespread support by browsers. Currently, not a single browser supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complex Complex issue requires design decissions
Projects
None yet
Development

No branches or pull requests

2 participants