Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 tests fail on Fedora 23 #13

Closed
akahl-owl opened this issue Feb 16, 2016 · 3 comments
Closed

Python2 tests fail on Fedora 23 #13

akahl-owl opened this issue Feb 16, 2016 · 3 comments

Comments

@akahl-owl
Copy link
Contributor

Running make test PYTHON=python2 gives me

python2 -m pylint.lint --rcfile .pylintrc kafkajournalpump/
************* Module kafkajournalpump.daemon
C:199, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
E: 32,15: Undefined variable 'FileNotFoundError' (undefined-variable)
E: 85,11: Undefined variable 'FileNotFoundError' (undefined-variable)
C: 96, 0: Old-style class defined. (old-style-class)
E:152,15: Undefined variable 'FileNotFoundError' (undefined-variable)
E:184,32: Undefined variable 'ProcessLookupError' (undefined-variable)
************* Module kafkajournalpump.kafkajournalpump
W:  9, 0: Module import itself (import-self)
C:205, 0: Old-style class defined. (old-style-class)
E:213,37: Module 'time' has no 'monotonic' member (no-member)
E:229,37: Module 'time' has no 'monotonic' member (no-member)
E:235,41: Module 'time' has no 'monotonic' member (no-member)
E:350,23: Module 'time' has no 'monotonic' member (no-member)
E:354,64: Module 'time' has no 'monotonic' member (no-member)
Makefile:15: recipe for target 'pylint' failed
make: *** [pylint] Error 22

OS: Fedora 23
python2 --version: 2.7.10

@saaros
Copy link
Contributor

saaros commented Feb 16, 2016

kafkajournalpump is a Python 3-only project. Will update README to say this.

@akahl-owl
Copy link
Contributor Author

Your RPM spec explicitly supports Python 2. Maybe you'll want to change that?

@saaros
Copy link
Contributor

saaros commented Feb 17, 2016

Yeah, the first version of the spec was probably copied from another of our projects that supported both Python 2 and 3, although kafkajournalpump never worked with Python 2. Removed Python 2 support from the spec in commit fb22d31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants