mypy: pglookout/webserver.py [BF-1560]
#101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 68.00% 69.29% +1.29%
==========================================
Files 10 11 +1
Lines 972 1013 +41
Branches 170 170
==========================================
+ Hits 661 702 +41
Misses 253 253
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Mulugruntz
commented
Mar 17, 2023
README.rst
Outdated
Comment on lines
335
to
338
| ``replication_catchup_timeout`` (default ``300.0``) | ||
|
|
||
| How long should pglookout wait for a node to catch up with the primary | ||
| before it decides to promote itself. |
There was a problem hiding this comment.
Whoever will review this PR, please make sure that the wording + the meaning are correct.
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_webserver
branch
from
139ada0
to
3277c36
Compare
Mulugruntz
changed the base branch from
main
to
sgiffard/BF-1560_add_typing/pglookout_config
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_webserver
branch
from
3277c36
to
8a553d4
Compare
|
ℹ️ For the reviewers: Please note this one is based on #96 . |
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_config
branch
from
9ddb56f
to
5aa2bff
Compare
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_webserver
branch
from
8a553d4
to
0dc17bb
Compare
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_config
branch
from
5aa2bff
to
84737ad
Compare
Mulugruntz
force-pushed
the
sgiffard/BF-1560_add_typing/pglookout_webserver
branch
from
0dc17bb
to
52bb635
Compare
|
This PR and the other ones related to type hinting will be handled in #106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.