Regenerate recovery information on config reload [BF-1812] #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packi
force-pushed
the
packi-regenerate-recover-conf-on-conninfo-change
branch
from
00b1567
to
87c42d6
Compare
packi
changed the title
alexole
reviewed
Apr 4, 2023
packi
force-pushed
the
packi-regenerate-recover-conf-on-conninfo-change
branch
3 times, most recently
from
71a5b41
to
e933ecb
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 68.20% 68.88% +0.68%
==========================================
Files 10 10
Lines 975 990 +15
Branches 171 173 +2
==========================================
+ Hits 665 682 +17
Misses 253 253
+ Partials 57 55 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kmichel-aiven
previously requested changes
Apr 12, 2023
This should be a no-op in most cases but in certain edge-cases (e.g. when changing a password) it can leave the standby without a possibility to connect to the primary and thus fall behind in replication.
packi
force-pushed
the
packi-regenerate-recover-conf-on-conninfo-change
branch
from
e933ecb
to
60e6dc6
Compare
kmichel-aiven
approved these changes
Apr 21, 2023
kmichel-aiven
deleted the
packi-regenerate-recover-conf-on-conninfo-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a no-op in most cases but in certain edge-cases (e.g. when changing a password) it can leave the standby without a possibility to connect to the primary and thus fall behind in replication.