fix replication lag warning to be always lower that failover timeout #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjamgade
force-pushed
the
warning-should-be-lower-than-timeout
branch
from
d2e183a
to
9673b46
Compare
rikonen
requested changes
Feb 24, 2021
There was a problem hiding this comment.
In addition to ensuring warning threshold is smaller than critical threshold also check_replication_lag needs to be adjusted so that it does not check whether value is over critical threshold if warning threshold was just exceeded, otherwise it's still possible both limits are exceeded at the same time and promotion happens without going through warning state.
sjamgade
force-pushed
the
warning-should-be-lower-than-timeout
branch
3 times, most recently
from
940ed43
to
5cd6bfb
Compare
rikonen
reviewed
Feb 24, 2021
Without this patch warning boundary could be set higher than failover timeout leading to warning file not created at all. As result warning handling mechanism never comes into play. This patch improves that behaviour by setting warning boundary to same as failover timeout
If pglookout is unable to do some periodic checks and comes back to notice replication lag has grown over failover limit because the replica was unresponsive, then its better to force one more check than straight jump to failover.
sjamgade
force-pushed
the
warning-should-be-lower-than-timeout
branch
from
5cd6bfb
to
3422690
Compare
rikonen
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch warning boundary could be set lower than failover
timeout leading to warning file not created at all. As result warning
handling mechanism never comes into play.
This patch improves that behaviour by setting warning boundary half the
failover timeout.