Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: pglookout/pgutil.py [BF-1560] #98

Closed

Conversation

Mulugruntz
Copy link
Contributor

No description provided.

@Mulugruntz Mulugruntz self-assigned this Mar 16, 2023
@Mulugruntz Mulugruntz requested a review from a team as a code owner March 16, 2023 16:31
@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_pgutil branch from f486036 to eba5e53 Compare March 16, 2023 16:33
@Mulugruntz Mulugruntz changed the title mypy: pglookout/pgutil.py [BF-1560] mypy: pglookout/pgutil.py [BF-1560] Mar 16, 2023
@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_pgutil branch 2 times, most recently from e4de558 to 88f77fa Compare March 16, 2023 16:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.59 🎉

Comparison is base (ca5f52e) 68.00% compared to head (111c0b4) 69.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   68.00%   69.59%   +1.59%     
==========================================
  Files          10       10              
  Lines         972     1023      +51     
  Branches      170      171       +1     
==========================================
+ Hits          661      712      +51     
  Misses        253      253              
  Partials       58       58              
Impacted Files Coverage Δ
pglookout/pgutil.py 95.72% <100.00%> (+3.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_pgutil branch from 88f77fa to 75b5715 Compare March 16, 2023 18:52
@aris-aiven
Copy link
Contributor

Can you rebase on main? (same for the other related PRs)

There's a Github feature to set the base branch for a PR to be another branch different than main. When the base branch is merged, the PR's base branch is automatically changed to main.

This way the PR branch only contains the incremental work, and not all dependent commits.

@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_pgutil branch from 75b5715 to 14e6896 Compare March 17, 2023 08:50
@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_pgutil branch from 14e6896 to 111c0b4 Compare March 22, 2023 11:20
@Mulugruntz
Copy link
Contributor Author

This PR and the other ones related to type hinting will be handled in #106.

@Mulugruntz Mulugruntz closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants