Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPS scaling list writer assumes 8 and only 8 indices #43

Open
fabiosky opened this issue Jul 7, 2021 · 0 comments
Open

SPS scaling list writer assumes 8 and only 8 indices #43

fabiosky opened this issue Jul 7, 2021 · 0 comments

Comments

@fabiosky
Copy link

fabiosky commented Jul 7, 2021

Hello,

in line:
https://github.com/aizvorski/h264bitstream/blob/master/h264_stream.c#L1727, it is assumed the count of seq_scaling_list_present_flag and ScalingListn*n always sum up to 8.

As I saw from the reader code:
https://github.com/aizvorski/h264bitstream/blob/master/h264_stream.c#L398
it seems the count is dependent from chroma_format_idc.

Should the write behave accordingly?

Thanks,
Fabio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabiosky