Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You need to wait a while between each ++, otherwise it won't work... #22

Closed
victorhooi opened this issue Sep 29, 2014 · 2 comments
Closed

Comments

@victorhooi
Copy link

I first applied the patch from zero1zero from here:

#21

After that, I was able to get the plugin to work. However, it doesn't seem to work if you issue "++" commands too quickly together.

For example:

jira++
Glados
jira has 1 points
Victor
jira++
jira++
jira++
Glados 12:43
jira has 2 points
Victor
jira++
jira++
jira++
Glados 12:43
jira has 2 points

So you need to issue one command, wait some while, before you're able to issue it again.

Has anybody else seen this issue?

@zero1zero
Copy link
Contributor

I have this same issue as well. I am seeing:

[Sat Sep 27 2014 01:34:25 GMT+0000 (UTC)] ERROR TypeError: Object dugan++ has no method 'pluck'
  at TextListener.callback (/usr/local/opt/hubot/node_modules/hubot-plusplus/src/plusplus.coffee:115:34, :69:46)
  at TextListener.Listener.call (/usr/local/opt/hubot/node_modules/hubot/src/listener.coffee:27:7, :23:14)
  at Robot.receive (/usr/local/opt/hubot/node_modules/hubot/src/robot.coffee:197:9, :142:33)
  at Slack.Adapter.receive (/usr/local/opt/hubot/node_modules/hubot/src/adapter.coffee:66:5, :47:25)
  at /usr/local/opt/hubot/node_modules/hubot-slack/src/slack.coffee:173:26, :175:16
  at callbacks (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/lib/router/index.js:161:37)
  at param (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/lib/router/index.js:135:11)
  at pass (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/lib/router/index.js:142:5)
  at Router._dispatch (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/lib/router/index.js:170:5)
  at Object.router (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/lib/router/index.js:33:10)
  at next (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/proto.js:190:15)
  at multipart (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/multipart.js:60:27)
  at /usr/local/opt/hubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:57:9
  at IncomingMessage. (/usr/local/opt/hubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/urlencoded.js:70:11)
  at IncomingMessage.EventEmitter.emit (events.js:92:17)
  at _stream_readable.js:920:16
  at process._tickCallback (node.js:415:13)

in the logs which may be related but I'm not sure.

@ajacksified
Copy link
Owner

https://github.com/ajacksified/hubot-plusplus/blob/master/src/scorekeeper.coffee#L84

This is an anti-spam feature, not a bug - a user can't ++ the same thing multiple times in a row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants