Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript@next removed/renamed TypeVariable #32

Closed
deregtd opened this issue Feb 22, 2018 · 7 comments
Closed

Typescript@next removed/renamed TypeVariable #32

deregtd opened this issue Feb 22, 2018 · 7 comments

Comments

@deregtd
Copy link

deregtd commented Feb 22, 2018

When using tsutils with the latest Typescript (typescript@next, currently 2.8.0-dev.20180221), they appear to have renamed the TypeVariable interface to InstantiableType. This changed somewhere between commits afc588eb9e6322faf55bc28f26994712e3f02261 and edffb120549536cefd73409cc87f0439dac722cf but I didn't dig deep enough to see where.

If you simply change ts.TypeVariable to ts.InstantiableType in typeguard/type.ts, that fixes the compile error in tsutils, but I don't know if that has other side effects that need investigating, or if you want to rename the checks as a result of the TS renaming.

@ajafff
Copy link
Owner

ajafff commented Feb 22, 2018

Thank you for the report. Unfortunately there's no easy way to fix this for you.
If I change the public API to be compatible with the upcoming typescript@2.8, it will break everyone else who's still using the latest release 2.7.2

I could however publish a new version as tsutils@next until typescript@2.8.1 is released.

@ajafff
Copy link
Owner

ajafff commented Feb 22, 2018

in the meantime you could set skipLibCheck: true in your compilerOptions.

@deregtd
Copy link
Author

deregtd commented Feb 22, 2018

Doing an @next would be awesome. I had to pull in tslint@next as well to fix some other issues with our lint rules, so it looks like in 2.8 they're changing some stuff that everyone's getting ready for. :)

@ajafff
Copy link
Owner

ajafff commented Feb 22, 2018

I'll work on this today and keep you posted here.
I'm a bit puzzled about the tslint@next thing, though ... There was no activity at all in the TSLint repo since the last stable release. tslint@next is v5.0.0-dev which is pretty old to say the least.

@deregtd
Copy link
Author

deregtd commented Feb 22, 2018

Oh right in the end I went up to 5.9.1 + tslint-microsoft-contrib 5.0.3 and that fixed the actual problem. I tried @next and that fixed one problem (compared to the version I was at), then had to bump again to 5.9.1 to get rid of the last of the issues. Ignore me on that. :)

@ajafff ajafff closed this as completed in 11da312 Feb 22, 2018
@ajafff
Copy link
Owner

ajafff commented Feb 22, 2018

@deregtd I actually found a way to make this fix backwards compatible. I just published v2.21.2 which compiles fine with typescript@next

@deregtd
Copy link
Author

deregtd commented Feb 22, 2018

Works great, thanks so much for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants