Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition style underline is wrong in dark themes #2761

Closed
vanillajonathan opened this issue Nov 11, 2015 · 3 comments
Closed

Composition style underline is wrong in dark themes #2761

vanillajonathan opened this issue Nov 11, 2015 · 3 comments

Comments

@vanillajonathan
Copy link
Contributor

Input composition is handled by the .ace_text-input.ace_composition class.

It seems the style is not handled so well by the dark themes, such as Pastel on dark, Terminal and Tomorrow Night, just to mention a few.

The underline is black, but it should be the same color as the text.

@nightwing
Copy link
Member

The underline is handled by browser/os, same issue is present for a textarea with background:black and color:white

@vanillajonathan
Copy link
Contributor Author

You are right.

I can confirm it on Chrome 46 running on Android 6.0: http://jsfiddle.net/os2xcmzL/

@nightwing nightwing added this to In progress in input-handling Jul 21, 2018
@nightwing
Copy link
Member

#3635 added useTextareaForIME option, setting it to false will draw custom underline of correct color.

@nightwing nightwing moved this from In progress to Done in input-handling Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants