Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete incorrect match highlighting when displaying caption #3069

Closed
shds86 opened this issue Aug 26, 2016 · 1 comment
Closed

Autocomplete incorrect match highlighting when displaying caption #3069

shds86 opened this issue Aug 26, 2016 · 1 comment

Comments

@shds86
Copy link
Contributor

shds86 commented Aug 26, 2016

I have some problem with autocomplite popup. In our suggestions we have length more than 32 symbols. But the Bitwise Left shift,

flag = data.matchMask & (1 << i) ? 1 : 0;
, is limited:

  • 1 << 30 has result 1073741824
  • 1 << 31 has result -2147483648

because bitwise operators treat their operands as a sequence of 32 bits,
therefore in next iterations we will have correct expression "data.matchMask & (1 << i)"

@austingreco
Copy link

See this PR: #2996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants