Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a config to disable ContextMenu on Touch #4069

Closed
eyedean opened this issue Sep 18, 2019 · 3 comments
Closed

Need a config to disable ContextMenu on Touch #4069

eyedean opened this issue Sep 18, 2019 · 3 comments

Comments

@eyedean
Copy link
Contributor

eyedean commented Sep 18, 2019

795bd6a has introduced touch/tap handling which was a requested feature (#3675). Thanks for providing it @nightwing. :)

The problem is, the context menu that pops is a bit problematic (at least on my Pixel XL, Chrome, Android 9). To be specific:

  1. The context menu is present even when the selection is empty. I am not sure if that's intended/wanted at all times.

  2. It shows up along with (and under) the native context menu:

Screenshot_20190918-151837

  1. There are cases (like mine) that I rather not have it show up at all. I have a custom mobile keyboard that provides the same functionalities elsewhere.

So, I was thinking maybe there should be an option to disable this.

For now I am just hiding it in CSS via .ace_mobile-menu { display: none !important }.

Thanks.

@tmpmachine
Copy link
Contributor

tmpmachine commented Jun 18, 2020

I think it is more preferable to style a mobile-friendly context menu.

I do the same thing (hiding ace mobile menu with CSS) until few weeks ago, I realize that it is more convenient to use ace context menu than the native one (because there are features like find, replace, undo, etc. on ace context menu, which is convenient on mobile). The only problem is that the styling is not mobile-friendly enough IMO, especially when you want to edit something at the end of the line and ace context menu is blocking the text.

@whazor
Copy link
Contributor

whazor commented Jun 5, 2024

#5580

@InspiredGuy
Copy link
Contributor

#5580 with a way to enable/disable mobile menu was merged, should be available in the next release.

Mobile support automation moved this from To do to Done Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants