Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly tokenize YAML meta tags with non alphabetical characters after multiline string #4706

Merged
merged 2 commits into from May 20, 2022

Conversation

andrewnester
Copy link
Contributor

Issue #, if available: #4694

Description of changes:
Correctly tokenize YAML meta tags with non alphabetical characters after multiline string

Previously match regex did not include non alphabetical characters in such meta tag keywords.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #4706 (c117c3b) into master (d59c22b) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4706      +/-   ##
==========================================
- Coverage   71.24%   71.19%   -0.06%     
==========================================
  Files         553      553              
  Lines       55598    55598              
  Branches    10392    10392              
==========================================
- Hits        39612    39584      -28     
- Misses      15986    16014      +28     
Flag Coverage Δ
unittests 71.19% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/mode/yaml_highlight_rules.js 86.84% <ø> (ø)
lib/ace/editor.js 79.64% <0.00%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59c22b...c117c3b. Read the comment docs.

@andrewnester andrewnester merged commit 0164811 into ajaxorg:master May 20, 2022
@andrewnester andrewnester deleted the yaml-tokenise branch May 20, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants