Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Image folding support (fold data: URL) #4755

Open
jorgk3 opened this issue Sep 11, 2020 · 7 comments
Open

Feature request: Image folding support (fold data: URL) #4755

jorgk3 opened this issue Sep 11, 2020 · 7 comments

Comments

@jorgk3
Copy link

jorgk3 commented Sep 11, 2020

This is a follow-up to:
https://github.com/ajaxorg/ace-builds/issues/147#issuecomment-449745497

I use the CSS suggested in that comment, but to make image folding work, I still need the patches as described in
https://github.com/ajaxorg/ace-builds/issues/147#issuecomment-448415677

I've just tried again with the latest release 1.4.12.

The background to this request is the following: As you are aware, Ace is embedded into the Thunderbird add-on ThunderHTMLedit. Each time a new version of add-on is uploaded to addons.thunderbird.net, it needs to go through a review process. The reviewers there prefer to approve a "stock standard" 3rd-party library and not a patched one. Also for me it would be easier to move to new versions if I didn't have to patch them.

So please let me know if you would consider this request, and if so, whether I can help in any form.

@andrewnester andrewnester transferred this issue from ajaxorg/ace-builds May 30, 2022
@InspiredGuy
Copy link
Contributor

The links in the issue lead to 404 page, could you please provide more context on the requested feature itself?

@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@jorgk3
Copy link
Author

jorgk3 commented Feb 24, 2023

Yes, "native" image folding would be lovely to have. Currently we're hacking it in ThunderHTMLedit.

@whazor
Copy link
Contributor

whazor commented Mar 3, 2023

To clarify, this would be code folding support in the HTML and CSS modes for:

<img src="data:image/jpeg;base64,/9j/4QCWRXhpZgAATU0AKgAAAAgABgEOAAIAAAAYAAAAVgEaAAUAAAABAAAAbgEbAAUAAAABAAAAdgEoAAMAAAABAAI ..."/>

Which would be useful as those images can be very big (800 KB image would be a lot of base64 letters).

That sounds like a useful feature yes.

@jorgk3
Copy link
Author

jorgk3 commented Mar 4, 2023

We hack it into place and it looks like this:
image
image

Please refer to https://github.com/ajaxorg/ace-builds/issues/147#issuecomment-448415677 and below.

Copy link

github-actions bot commented Mar 4, 2024

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@jorgk3
Copy link
Author

jorgk3 commented Mar 4, 2024

That sounds like a useful feature yes.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants