Use mini require #4845
Merged
Use mini require #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightwing
force-pushed
the
use-mini_require
branch
from
a606fad
to
30ea87e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
+ Coverage 69.94% 70.05% +0.10%
==========================================
Files 559 557 -2
Lines 58338 58218 -120
Branches 11235 11195 -40
==========================================
- Hits 40805 40783 -22
+ Misses 17533 17435 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -36,8 +36,7 @@ | |||
|
|
|||
| define(function(require, exports, module) { | |||
| "use strict"; | |||
|
|
|||
| require("./lib/fixoldbrowsers"); | |||
| "include loader_build"; | |||
There was a problem hiding this comment.
If I understand correctly, this is a breaking change for those who consume Ace directly via source code, right?
There was a problem hiding this comment.
I think it is not, because the things we use from fixoldbrowsers are already supported on all browsers we support, so this was only adding bloat to ace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will allow to use cjs code in browser without a bundler.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.