Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gutter icons #4977

Closed
2 tasks
vanillajonathan opened this issue Nov 1, 2022 · 4 comments
Closed
2 tasks

New gutter icons #4977

vanillajonathan opened this issue Nov 1, 2022 · 4 comments

Comments

@vanillajonathan
Copy link
Contributor

Describe the feature

New redesigned gutter icons (warning and error) with modern aesthetics; clean solid colors without color fading.
Use SVG so the icons look good on HiDPI screens, when zooming and with larger font sizes.

Bootstrap have suitable icons available under the MIT License:

Use Case

Make Ace look more modern, increase accessibility, work better with larger font sizes.

Proposed Solution

Redesign the icons with modern aesthetics; clean solid colors without color fading.
Redesign the icons as SVG so they work well with larger font sizes.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

ACE version used

1.12.5

@akoreman
Copy link
Contributor

akoreman commented Apr 7, 2023

In #5107 we added an option to use SVG gutter icons, this will be released in the next Ace release (1.17.0).

After this release you can set the useSvgGutterIcons option to true to have SVG icons for annotations in the gutter. By setting the background-color for .ace_icon_svg.ace_error, .ace_icon_svg.ace_warning and .ace_icon_svg.ace_info you can set the color of these SVG icons.

@vanillajonathan
Copy link
Contributor Author

Maybe just always use the SVG icons and remove the old icons?
Why should this even be an option?

@InspiredGuy
Copy link
Contributor

Closing as the option to use SVG icons was released in v1.17.0.

Accessibility automation moved this from To do to Done May 16, 2023
@vanillajonathan
Copy link
Contributor Author

I propose the option be removed and that SVG icons always be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants