fix: console error when hovering over empty gutter cell with tooltipFollowsMouse set to false #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5173 +/- ##
=======================================
Coverage 86.95% 86.96%
=======================================
Files 562 562
Lines 44997 45018 +21
Branches 6921 6923 +2
=======================================
+ Hits 39128 39148 +20
- Misses 5869 5870 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nightwing
approved these changes
May 16, 2023
InspiredGuy
approved these changes
May 16, 2023
akoreman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hovering over an empty gutter cell with
tooltipFollowsMouseset tofalse, a console error is thrown because the querySelector is trying to find an non-existing element. This fixes that by checking whether there is an annotation in the row before trying to show the tooltip.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.