feat(autocomplete): ellipsis is shown when suggestions is longer than popover width #5204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oykuyilmaz
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5204 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 565 565
Lines 45075 45075
Branches 6910 6910
=======================================
Hits 39295 39295
Misses 5780 5780
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Do you know how screenreaders react to overflowed content shown by ellipsis? Does it read out the full content, read out the visual lines + something like 'more content available' or not read out the overflown content at all? |
|
Yes, they do read the whole content as some other text editor does. We can discuss what is preferred. |
oykuyilmaz
commented
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the completion suggestion is larger than the autocomplete popover width, we need to show elipsis(...) to convey this information.
This PR also makes right-alignment of meta default fixing #3785.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.