Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression setting gutter tooltip classname #5211

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

akoreman
Copy link
Contributor

Issue: #5209

Description of changes: When calling setTheme we overrode the ace_gutter-tooltip class we set to the gutter tooltip.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (538b18c) 87.19% compared to head (12e5aef) 87.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5211   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         565      565           
  Lines       45121    45122    +1     
  Branches     6910     6910           
=======================================
+ Hits        39342    39343    +1     
  Misses       5779     5779           
Flag Coverage Δ
unittests 87.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mouse/default_gutter_handler.js 72.97% <100.00%> (+0.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InspiredGuy InspiredGuy merged commit 5bdb944 into ajaxorg:master Jun 20, 2023
3 checks passed
@akoreman akoreman deleted the gutter_tooltip_class_fix branch June 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GutterTooltip: CSS class ace_gutter-tooltip is not set properly when opening the tooltip
2 participants